Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller: close kvclient correctly when stopping a processor (#11957) #11982

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11957

What problem does this PR solve?

Issue Number: close #11954

What is changed and how it works?

When stopping a processor, close the associated puller.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
[2024/12/31 16:21:32.261 +08:00] [INFO] [multiplexing_puller.go:331] ["MultiplexingPuller exits"] [namespace=default] [changefeed=x3_owner_ddl_puller]
[2024/12/31 16:21:32.270 +08:00] [INFO] [multiplexing_puller.go:366] ["MultiplexingPuller is closed"] [namespace=default] [changefeed=x3_owner_ddl_puller]
[2024/12/31 16:21:32.273 +08:00] [INFO] [multiplexing_puller.go:331] ["MultiplexingPuller exits"] [namespace=default] [changefeed=x3]
[2024/12/31 16:21:32.273 +08:00] [INFO] [multiplexing_puller.go:366] ["MultiplexingPuller is closed"] [namespace=default] [changefeed=x3]
[2024/12/31 16:21:32.273 +08:00] [INFO] [multiplexing_puller.go:331] ["MultiplexingPuller exits"] [namespace=default] [changefeed=x3_processor_ddl_puller]
[2024/12/31 16:21:32.273 +08:00] [INFO] [multiplexing_puller.go:366] ["MultiplexingPuller is closed"] [namespace=default] [changefeed=x3_processor_ddl_puller]

With the patch, when removing a changefeed, all pullers for owner_ddl, processor_ddl and source_manager are closed.
No goroutine leak happens any more.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

hicqu added 6 commits January 6, 2025 14:03
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 41.37931% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@0e6b44f). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 59.7139% <0.0000%> (?)
dm 50.0673% <0.0000%> (?)
engine 53.1997% <0.0000%> (?)
Flag Coverage Δ
unit 55.1997% <41.3793%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #11982   +/-   ##
================================================
  Coverage               ?   55.1997%           
================================================
  Files                  ?       1002           
  Lines                  ?     136575           
  Branches               ?          0           
================================================
  Hits                   ?      75389           
  Misses                 ?      55671           
  Partials               ?       5515           

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 7, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 7, 2025
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jan 8, 2025

/test pull-dm-compatibility-test

2 similar comments
@wk989898
Copy link
Collaborator

wk989898 commented Jan 9, 2025

/test pull-dm-compatibility-test

@wk989898
Copy link
Collaborator

wk989898 commented Jan 9, 2025

/test pull-dm-compatibility-test

@ti-chi-bot ti-chi-bot bot merged commit 0eb416d into pingcap:release-8.5 Jan 9, 2025
27 checks passed
@hicqu hicqu deleted the cherry-pick-11957-to-release-8.5 branch January 14, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants