-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puller: close kvclient correctly when stopping a processor (#11957) #11982
puller: close kvclient correctly when stopping a processor (#11957) #11982
Conversation
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Signed-off-by: qupeng <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.5 #11982 +/- ##
================================================
Coverage ? 55.1997%
================================================
Files ? 1002
Lines ? 136575
Branches ? 0
================================================
Hits ? 75389
Misses ? 55671
Partials ? 5515 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-dm-compatibility-test |
2 similar comments
/test pull-dm-compatibility-test |
/test pull-dm-compatibility-test |
This is an automated cherry-pick of #11957
What problem does this PR solve?
Issue Number: close #11954
What is changed and how it works?
When stopping a processor, close the associated puller.
Check List
Tests
With the patch, when removing a changefeed, all pullers for
owner_ddl
,processor_ddl
andsource_manager
are closed.No goroutine leak happens any more.
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note