-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default tab in settings with update to Feed to Recent #631
base: main
Are you sure you want to change the base?
Conversation
@nunomaduro @MrPunyapal please have a look. |
database/migrations/2024_09_19_125543_add_default_tab_to_users.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Punyapal Shah <[email protected]>
database/migrations/2024_09_19_125543_add_default_tab_to_users.php
Outdated
Show resolved
Hide resolved
…at/default-tab-454
…at/default-tab-454
@nunomaduro anything else you want me to update in this one? |
where are we on this one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out the PR locally, looks good.
I think adding the following change to navigation.blade.php
home icon, would really enhance this feature. I find myself clicking on the home button when I go from someones profile back to the feeds, so I feel it's important to reflect the users choice when clicking the home button.
@php($defaultTab = auth()?->user()->default_tab ?? 'recent')
<a
title="Home"
href="{{ route("home.{$defaultTab}") }}"
class=""
wire:navigate
>
@MrPunyapal Wdyt?
Agreed! |
Updated. |
@CamKem, the requested changes have been made, can you please approve the changes if there is nothing needs to be added? |
@msamgan can you rebase? |
Co-authored-by: Punyapal Shah <[email protected]>
# Conflicts: # resources/views/layouts/navigation.blade.php
@MrPunyapal "data-pan="home-tabs-feed"" should i change this to "data-pan="home-tabs-recent" ? |
all done... |
#454
--Screen.Recording.2024-09-19.at.11.40.57.AM.mov