Address comments

pinterest · Nov 20, 2024 · 8bb3260 · 8bb3260
1 parent 7bb4f30
commit 8bb3260
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/...rver/src/main/java/com/pinterest/orion/core/utils/memq/zookeeper/MemqZookeeperClient.java b/...rver/src/main/java/com/pinterest/orion/core/utils/memq/zookeeper/MemqZookeeperClient.java
@@ -11,7 +11,7 @@ public class MemqZookeeperClient {
     public static final String BROKERS = "/brokers";
     public static final String TOPICS = "/topics";
     public static final String GOVERNOR = "/governor";
-    private boolean refreshZkClientWhenException = true;
+    private boolean refreshZkClientOnException = true;
     private String zkUrl;
     private MemqCluster cluster;
     private CuratorFramework zkClient;
@@ -26,12 +26,12 @@ public MemqZookeeperClient(MemqCluster cluster) throws Exception {
         }
     }
 
-    public void enableRefreshZkClientWhenException() {
-        this.refreshZkClientWhenException = true;
+    public void enableRefreshZkClientOnException() {
+        this.refreshZkClientOnException = true;
     }
 
-    public void disableRefreshZkClientWhenException() {
-        this.refreshZkClientWhenException = false;
+    public void disableRefreshZkClientOnException() {
+        this.refreshZkClientOnException = false;
     }
 
     /**
@@ -61,7 +61,7 @@ public void refreshZkClient() throws Exception {
 
     /**
      * Get the children of a node in Zookeeper.
-     * When an exception occurs, the Zookeeper client is refreshed and the children are fetched again if the refreshZkClientWhenException flag is set.
+     * When an exception occurs, the Zookeeper client is refreshed and the children are fetched again if the refreshZkClientOnException flag is set.
      * @param path The path of the node.
      * @return List of children node names.
      * @throws Exception
@@ -70,7 +70,7 @@ private List<String> getChildNodes(String path) throws Exception {
         try {
             return zkClient.getChildren().forPath(path);
         } catch (Exception e) {
-            if (refreshZkClientWhenException) {
+            if (refreshZkClientOnException) {
                 refreshZkClient();
                 return zkClient.getChildren().forPath(path);
             } else {
@@ -81,7 +81,7 @@ private List<String> getChildNodes(String path) throws Exception {
 
     /**
      * Get the data of a node in Zookeeper.
-     * When an exception occurs, the Zookeeper client is refreshed and the data is fetched again if the refreshZkClientWhenException flag is set.
+     * When an exception occurs, the Zookeeper client is refreshed and the data is fetched again if the refreshZkClientOnException flag is set.
      * @param path The path of the node.
      * @return The data of the node as a json string
      * @throws Exception
@@ -90,7 +90,7 @@ private String getNodeData(String path) throws Exception {
         try {
             return new String(zkClient.getData().forPath(path));
         } catch (Exception e) {
-            if (refreshZkClientWhenException) {
+            if (refreshZkClientOnException) {
                 refreshZkClient();
                 return new String(zkClient.getData().forPath(path));
             } else {