WIP all sink tests pass

pinterest · Sep 26, 2024 · addce63 · addce63
1 parent bd41598
commit addce63
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscCommitterTest.java b/psc-flink/src/test/java/com/pinterest/flink/connector/psc/sink/PscCommitterTest.java
@@ -107,7 +107,9 @@ public void commitTransaction() {}
                     public void flush() {}
 
                     @Override
-                    public void close() {}
+                    public void close() throws IOException {
+                        super.close();
+                    }
                 };
         try (final PscCommitter committer = new PscCommitter(properties);
                 Recyclable<FlinkPscInternalProducer<Object, Object>> recyclable =
@@ -118,6 +120,7 @@ public void close() {}
 
             committer.commit(Collections.singletonList(request));
             assertThat(recyclable.isRecycled()).isTrue();
+            producer.close();
         }
     }
 

diff --git a/...nk/src/test/java/com/pinterest/flink/connector/psc/sink/PscWriterStateSerializerTest.java b/...nk/src/test/java/com/pinterest/flink/connector/psc/sink/PscWriterStateSerializerTest.java
@@ -25,8 +25,8 @@
 import static org.junit.Assert.assertEquals;
 
 /**
- * Tests for serializing and deserialzing {@link KafkaWriterState} with {@link
- * KafkaWriterStateSerializer}.
+ * Tests for serializing and deserialzing {@link PscWriterState} with {@link
+ * PscWriterStateSerializer}.
  */
 public class PscWriterStateSerializerTest extends TestLogger {