Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Pinterest delta table tooltip feature on timeseries charts #34

Merged
merged 3 commits into from
Nov 8, 2024
Merged

feat: Implement Pinterest delta table tooltip feature on timeseries charts #34

merged 3 commits into from
Nov 8, 2024

Conversation

kgopal492
Copy link

@kgopal492 kgopal492 commented Nov 7, 2024 •
edited
Loading

SUMMARY

Settings: (can toggle a feature, can
Screenshot 2024-11-06 at 4 23 46 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-11-07 at 3 11 31 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgopal492 kgopal492 changed the title feat: Implement Pinterest delta table tooltip feature on timeseries charts\ feat: Implement Pinterest delta table tooltip feature on timeseries charts Nov 7, 2024
@kgopal492 kgopal492 merged commit 86b7180 into pinterest:pinterest-release-4.0.2 Nov 8, 2024
13 of 20 checks passed
kgopal492 added a commit that referenced this pull request Jan 27, 2025
@kgopal492
feat: Implement Pinterest delta table tooltip feature on timeseries c…
398692e 
…harts (#34)

* Implement Pinterest delta table tooltip feature on timeseries charts

* Fixes

* pr fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczhong84 jczhong84 jczhong84 approved these changes

Assignees
No one assigned
Labels
dependencies:npm plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kgopal492 @jczhong84