Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daylight savings bug in Pinterest delta table tooltip #37

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix daylight savings bug in Pinterest delta table tooltip #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions superset-frontend/plugins/plugin-chart-echarts/src/pinterest-utils/tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,17 @@ import { getTooltipTimeFormatter } from '../utils/formatters';
import { DeltaDirection, DeltaTableColumn } from './types';

const getPreviousDate = (date: Date, offsetDays: number) => {
const previousDate = new Date(date);
previousDate.setDate(date.getDate() - offsetDays);
return previousDate;
// Convert the date to UTC time in milliseconds, subtract the offsetDays,
// and return the new date. (UTC conversion is needed to avoid daylight savings issues)
const time = Date.UTC(
date.getUTCFullYear(),
date.getUTCMonth(),
date.getUTCDate(),
);
// subtract offsetDays from the time in milliseconds
const newTime = time - offsetDays * 24 * 60 * 60 * 1000;
const newDate = new Date(newTime);
return newDate;
};

export const getDateByTimeDelta = {
Expand Down
Loading