Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version upgrade): Make fixes to upgrade to v4.1.1 #44

Merged

Conversation

kgopal492
Copy link

SUMMARY

Make various changes to support upgrade to v4.1.1

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgopal492 kgopal492 changed the title Make fixes to upgrade to v4.1.1 fix(version upgrade): Make fixes to upgrade to v4.1.1 Jan 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (pinterest-release-4.1.1@e96f17d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
superset/migrations/env.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             pinterest-release-4.1.1      #44   +/-   ##
==========================================================
  Coverage                           ?   83.62%           
==========================================================
  Files                              ?      535           
  Lines                              ?    38535           
  Branches                           ?        0           
==========================================================
  Hits                               ?    32223           
  Misses                             ?     6312           
  Partials                           ?        0           
Flag Coverage Δ
hive 48.93% <50.00%> (?)
postgres 76.86% <50.00%> (?)
presto 53.43% <50.00%> (?)
python 83.62% <50.00%> (?)
sqlite 76.33% <50.00%> (?)
unit 60.25% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgopal492 kgopal492 merged commit bfc4be1 into pinterest:pinterest-release-4.1.1 Feb 4, 2025
16 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants