Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Add option to filter by template parameters #45

Conversation

kgopal492
Copy link

@kgopal492 kgopal492 commented Feb 11, 2025

SUMMARY

Add feature to filter chart by template parameters.
Rationale: users might want to test jinja filters or access jinja filters that are only available within the SQL query.
Screenshot 2025-02-18 at 1 12 38 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api label Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (pinterest-release-4.1.1@bfc4be1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
superset/datasets/template_columns/api.py 76.47% 8 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             pinterest-release-4.1.1      #45   +/-   ##
==========================================================
  Coverage                           ?   83.67%           
==========================================================
  Files                              ?      538           
  Lines                              ?    38625           
  Branches                           ?        0           
==========================================================
  Hits                               ?    32319           
  Misses                             ?     6306           
  Partials                           ?        0           
Flag Coverage Δ
hive 48.96% <64.36%> (?)
mysql 76.74% <64.36%> (?)
postgres 76.83% <64.36%> (?)
presto 53.45% <64.36%> (?)
python 83.67% <90.80%> (?)
sqlite 76.30% <64.36%> (?)
unit 60.43% <90.80%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the doc label Feb 18, 2025
@kgopal492 kgopal492 merged commit 0e495f0 into pinterest:pinterest-release-4.1.1 Feb 19, 2025
18 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants