Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the first run using docker #809

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

disparter
Copy link
Contributor

@disparter disparter commented Mar 18, 2021

Fixed bug on schema-updates

Removed the extra comma in the schema-update-8.sql (syntax issue)
Changed the NO-BREAK-SPACE to a Space in schema-update-(11-7-9-8)

Expectations
In the first run of Teletraan, after create database it has to be on version 11

Test Plan

  1. docker-compose up --build
  2. docker exec teletraan_pinterest_mysql /var/teletraan/tools/deploydb.sh -f /var/tools/check_version.sql

Fixed encoding for files saved as UTF8 to ASCII

Using space instead of No-Break-Space
@disparter disparter requested a review from a team as a code owner March 18, 2021 22:52
@disparter
Copy link
Contributor Author

I think this PR fix this issue:
#700
But I will double check tomorrow

deploy-agent/deployd/common/config.py Outdated Show resolved Hide resolved
deploy-agent/deployd/conf/agent.conf Outdated Show resolved Hide resolved
@disparter disparter force-pushed the firstrun-docker-fix branch from a05d948 to 0e4a12b Compare March 25, 2021 23:46
@disparter
Copy link
Contributor Author

Removed the hardcoded version and reusing version declaration in init
that solves on Mac and we will only changing version in the same place

Copy link
Contributor

@robbintt robbintt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@disparter disparter merged commit dd79b86 into pinterest:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants