Refactor addrFromAnswerHeader logic with a switch #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
==========================================
+ Coverage 65.75% 66.46% +0.71%
==========================================
Files 1 1
Lines 838 841 +3
==========================================
+ Hits 551 559 +8
+ Misses 209 206 -3
+ Partials 78 76 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoeTurki
force-pushed
the
refactor/addrFromAnswerHeader
branch
from
ce529a1 to
2bf28f4
Compare
Replaced the if-else structure with a switch statement for better readability and future extensibility, Added a default case to handle unsupported record types explicitly (Never happens)
JoeTurki
force-pushed
the
refactor/addrFromAnswerHeader
branch
from
2bf28f4 to
befed39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the if-else structure with a switch statement for better readability and future extensibility, Added a default case to handle unsupported record types explicitly (Never happens)