Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix goroutine leakage #292

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Conversation

enobufs
Copy link
Member

@enobufs enobufs commented Dec 29, 2023

Description

  • Added reproducible leakage check along with a fix.
  • Fixed a test case that had a goroutine that did not exit.
  • Ubuntu linux appears to have a bug causing initial packet exchange to fail (see issue Flaky tests and/or goroutine leaks #270 for details). To workaround it, the test tool createAssocs() has been updated to use "dumbConn2" (similar to the existing "dumbConn" which uses test.Bridge.) instead of using kernel routing between the two net.Conn endpoints.

Reference issue

Fixes #270

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1abdf2d) 67.23% compared to head (91bc4b1) 80.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #292       +/-   ##
===========================================
+ Coverage   67.23%   80.53%   +13.29%     
===========================================
  Files          48       48               
  Lines        4047     4053        +6     
===========================================
+ Hits         2721     3264      +543     
+ Misses       1172      647      -525     
+ Partials      154      142       -12     
Flag Coverage Δ
go 80.53% <100.00%> (?)
wasm 67.18% <33.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enobufs enobufs changed the title Fix goroutine leakage [WIP] Fix goroutine leakage Dec 30, 2023
@enobufs enobufs force-pushed the 270_fix_goroutine_leakage_in_the_test branch from cd16b2f to 9f81582 Compare December 30, 2023 07:57
@enobufs enobufs force-pushed the 270_fix_goroutine_leakage_in_the_test branch 3 times, most recently from c5459ae to 6aa7423 Compare January 1, 2024 08:13
@enobufs enobufs requested review from stv0g and mengelbart January 1, 2024 09:01
@enobufs enobufs self-assigned this Jan 1, 2024
@enobufs enobufs requested a review from Sean-Der January 5, 2024 05:48
Added reproducible leakage check along with a fix.
Use checkGoroutineLeaks everywhere.
This is avoid the issue with unexpected errors occur on Ubuntu linux.
Relates to #270
@Sean-Der Sean-Der force-pushed the 270_fix_goroutine_leakage_in_the_test branch from 04ed1c4 to 91bc4b1 Compare January 6, 2024 00:55
@Sean-Der Sean-Der merged commit 4bb25dc into master Jan 6, 2024
14 checks passed
@Sean-Der Sean-Der deleted the 270_fix_goroutine_leakage_in_the_test branch January 6, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests and/or goroutine leaks
2 participants