Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #214

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Upgrade golangci-lint, more linters #214

merged 1 commit into from
Jan 19, 2025

Conversation

JoeTurki
Copy link
Member

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Reference issue

pion/.goassets#220

@JoeTurki JoeTurki mentioned this pull request Jan 18, 2025
20 tasks
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 47 lines in your changes missing coverage. Please review.

Project coverage is 65.35%. Comparing base (be5e65e) to head (0397f21).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/stun-nat-behaviour/main.go 0.00% 16 Missing ⚠️
stuntest/udp_server.go 0.00% 10 Missing ⚠️
cmd/stun-multiplex/main.go 0.00% 7 Missing ⚠️
cmd/stun-bench/main.go 0.00% 4 Missing ⚠️
cmd/stun-traversal/main.go 0.00% 4 Missing ⚠️
cmd/stun-client/stun_client.go 0.00% 3 Missing ⚠️
addr.go 87.50% 2 Missing ⚠️
e2e/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   65.15%   65.35%   +0.19%     
==========================================
  Files          27       27              
  Lines        2540     2644     +104     
==========================================
+ Hits         1655     1728      +73     
- Misses        876      907      +31     
  Partials        9        9              
Flag Coverage Δ
go 65.35% <83.33%> (+0.19%) ⬆️
wasm 42.13% <52.83%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@JoeTurki JoeTurki marked this pull request as draft January 18, 2025 16:58
@JoeTurki JoeTurki marked this pull request as ready for review January 19, 2025 12:28
@JoeTurki JoeTurki merged commit 0397f21 into master Jan 19, 2025
15 checks passed
@JoeTurki JoeTurki deleted the impr/lint branch January 19, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant