Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #324

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Upgrade golangci-lint, more linters #324

merged 1 commit into from
Jan 16, 2025

Conversation

JoeTurki
Copy link
Member

Description

Introduces new linters and resolves issues with the latest golangci-lint version (v1.63.4).

pion/.goassets#220

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 85.18519% with 32 lines in your changes missing coverage. Please review.

Project coverage is 81.79%. Comparing base (527176e) to head (839bffc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vnet/router.go 80.00% 6 Missing and 1 partial ⚠️
test/bridge.go 70.58% 5 Missing ⚠️
connctx/connctx.go 60.00% 2 Missing ⚠️
netctx/conn.go 60.00% 2 Missing ⚠️
netctx/packetconn.go 60.00% 2 Missing ⚠️
udp/batchconn.go 33.33% 2 Missing ⚠️
udp/conn.go 88.23% 2 Missing ⚠️
vnet/nat.go 90.90% 0 Missing and 2 partials ⚠️
connctx/pipe.go 0.00% 1 Missing ⚠️
deadline/deadline.go 85.71% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   81.86%   81.79%   -0.08%     
==========================================
  Files          39       39              
  Lines        3337     3445     +108     
==========================================
+ Hits         2732     2818      +86     
- Misses        478      500      +22     
  Partials      127      127              
Flag Coverage Δ
go 81.70% <85.18%> (-0.07%) ⬇️
wasm 63.99% <66.20%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
@JoeTurki JoeTurki mentioned this pull request Jan 15, 2025
20 tasks
@JoeTurki JoeTurki merged commit 839bffc into master Jan 16, 2025
15 checks passed
@JoeTurki JoeTurki deleted the add/linters branch January 16, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant