Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codegen image version #4970

Merged
merged 7 commits into from
Jun 14, 2024
Merged

Update codegen image version #4970

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5974ae4
Update codegen image version
ffjlabo Jun 13, 2024
206c510
Update codegen image hash in the CI
ffjlabo Jun 13, 2024
2988d0b
Fix to use image hash in Makefile
ffjlabo Jun 13, 2024
3624aed
For checking cpu arch
ffjlabo Jun 13, 2024
c9958c5
Fix codegen image hash
ffjlabo Jun 14, 2024
b06e221
Remove checking cpu arch
ffjlabo Jun 14, 2024
f609eae
Merge branch 'master' into update-codegen-image-hash
ffjlabo Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ update/copyright:
.PHONY: gen/code
gen/code:
# NOTE: Specify a specific version temporally until the next release.
docker run --rm -v ${PWD}:/repo -it --entrypoint ./tool/codegen/codegen.sh ghcr.io/pipe-cd/codegen@sha256:fc3db505ef8dbf287b90aafed8c28246d2cca06bda2b43893a3059719fe9fff4 /repo #v0.44.0-38-g7229285
docker run --rm -v ${PWD}:/repo -it --entrypoint ./tool/codegen/codegen.sh ghcr.io/pipe-cd/codegen:v0.47.3-rc0-1-g7e27cad /repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about specifying the image with sha256 hash, as specified in the PR's base commit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
Is the sha256 hash better than specifying version?
I don't have a strong opinion, but I felt redundant hash with version comment like the base commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image specified with the tag can be overwritten, such as the git tag.
Conversely, the sha256 hash is immutable, such as the git commit hash.
So, specifying with the sha256 hash is more reproducible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got your point! Thank you! I'll fix it.


.PHONY: gen/test-tls
gen/test-tls:
Expand Down
Loading