Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make release for major/minor releases #5225

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Use make release for major/minor releases #5225

merged 3 commits into from
Sep 24, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Sep 24, 2024

What this PR does / why we need it:

  1. Uses make release instead of make release/init and make release/docs for major/minor releases.
    cf.

    pipecd/Makefile

    Lines 218 to 231 in 909fd76

    .PHONY: release
    release: release/init release/docs
    .PHONY: release/init
    release/init:
    ./hack/gen-release.sh $(version)
    .PHONY: release/pick
    release/pick:
    ./hack/cherry-pick.sh $(branch) $(pull_numbers)
    .PHONY: release/docs
    release/docs:
    ./hack/gen-release-docs.sh $(version)

  2. Directly specifies to use make release/init for patch releases.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit e317934 into master Sep 24, 2024
13 of 15 checks passed
@t-kikuc t-kikuc deleted the simplify-releases branch September 24, 2024 06:11
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.83%. Comparing base (909fd76) to head (c4ac261).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5225   +/-   ##
=======================================
  Coverage   22.82%   22.83%           
=======================================
  Files         419      419           
  Lines       45304    45304           
=======================================
+ Hits        10340    10344    +4     
+ Misses      34169    34165    -4     
  Partials      795      795           
Flag Coverage Δ
22.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants