-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade aws-sdk-go-v2 #5241
Upgrade aws-sdk-go-v2 #5241
Conversation
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5241 +/- ##
==========================================
+ Coverage 22.92% 23.99% +1.07%
==========================================
Files 420 438 +18
Lines 45336 47050 +1714
==========================================
+ Hits 10392 11291 +899
- Misses 34147 34857 +710
- Partials 797 902 +105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <[email protected]>
reopen for rerun snyk test |
re:reopen for rerun snyk test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
* Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * upgrade aws-sdk-go-v2 Signed-off-by: t-kikuc <[email protected]> * upgrade aws-sdk-go-v2/**/* Signed-off-by: t-kikuc <[email protected]> * fix compile errors caused by the breaking change Signed-off-by: t-kikuc <[email protected]> * fix a test due to added RestartPolicy Signed-off-by: t-kikuc <[email protected]> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <[email protected]> * fix go.sum by `make update/go-deps` Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
#5263 (#5265) * Fix panic in ECS driftdetection when a taskdef in livestates does not exist (#5240) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Upgrade aws-sdk-go-v2 (#5241) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * upgrade aws-sdk-go-v2 Signed-off-by: t-kikuc <[email protected]> * upgrade aws-sdk-go-v2/**/* Signed-off-by: t-kikuc <[email protected]> * fix compile errors caused by the breaking change Signed-off-by: t-kikuc <[email protected]> * fix a test due to added RestartPolicy Signed-off-by: t-kikuc <[email protected]> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <[email protected]> * fix go.sum by `make update/go-deps` Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Remove an unused field 'configFilePathInGitRepo' (#5248) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * remove unused field 'configFilePathInGitRepo' Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Support fetching a piped config from AWS SSM Parameter Store (#5249) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * add --aws-ssm-parameter Signed-off-by: t-kikuc <[email protected]> * add config-aws-ssm-parameter to piped Signed-off-by: t-kikuc <[email protected]> * update docs of runtime options Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Remove subnet ordering in head manifest (#5254) Signed-off-by: HoangNguyen689 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Update quickstart header note (#5255) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Update feature status (#5256) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Support directly designating a gitSSHKey instead of File for launcher (#5258) * Generate v0.49.x docs Signed-off-by: t-kikuc <[email protected]> * add --git-ssh-key-env Signed-off-by: t-kikuc <[email protected]> * update docs: add '--git-ssh-key-env' Signed-off-by: t-kikuc <[email protected]> * add '\n' at the end of ssh key Signed-off-by: t-kikuc <[email protected]> * Directly use data instead of env Signed-off-by: t-kikuc <[email protected]> * Clarify the flag description Signed-off-by: t-kikuc <[email protected]> * fix error message: 'and' -> 'or' Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Add workflow steps to build and publish quickstart manifests (#5260) Signed-off-by: pipecd-bot <[email protected]> * Update workflow not to run by matrix (#5262) Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Update RELEASE to v0.49.1 and update v0.49.x docs (#5263) * update RELEASE to v0.49.1 Signed-off-by: t-kikuc <[email protected]> * update docs of v0.49.x by `make release version=v0.49.1` Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: HoangNguyen689 <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]> Co-authored-by: Tetsuya Kikuchi <[email protected]> Co-authored-by: HoangNguyen689 <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]>
What this PR does / why we need it:
Mainly:
aws-sdk-go-v2
especiallyaws-sdk-go-v2/service/ecs
Associated tasks:
aws-sdk-go-v2/**/*
to solve the breaking change.pkg/filestore/s3/s3.go
andpkg/app/piped/platformprovider/ecs/client.go
RestartPolicy
is added and the row number slidedpkg/app/piped/platformprovider/ecs/diff_test.go
Which issue(s) this PR fixes:
Fixes #5144
Does this PR introduce a user-facing change?: