Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use index from requests in buildQuickSyncPipeline #5242

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 30, 2024

What this PR does / why we need it:

as title

Which issue(s) this PR fixes:

Part of #4980
Follows #5231

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.95%. Comparing base (c1a06aa) to head (4d31583).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/kubernetes/deployment/pipeline.go 75.00% 1 Missing ⚠️
...app/pipedv1/plugin/kubernetes/deployment/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5242   +/-   ##
=======================================
  Coverage   23.95%   23.95%           
=======================================
  Files         437      437           
  Lines       46997    46997           
=======================================
  Hits        11258    11258           
  Misses      34835    34835           
  Partials      904      904           
Flag Coverage Δ
23.95% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@khanhtc1202 khanhtc1202 merged commit c16aebb into master Oct 1, 2024
17 checks passed
@khanhtc1202 khanhtc1202 deleted the k8s-plugin-build-qs-stage-index branch October 1, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants