Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LoadManifests with Kustomize template #5291

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Oct 24, 2024

What this PR does:

as title

Why we need it:

We must support the kustomize templating method in the k8s plugin because the pipedv0 supports it.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 65.85366% with 14 lines in your changes missing coverage. Please review.

Project coverage is 24.41%. Comparing base (c265522) to head (07ad220).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...g/app/pipedv1/plugin/kubernetes/provider/loader.go 0.00% 11 Missing ⚠️
...pp/pipedv1/plugin/kubernetes/provider/kustomize.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5291      +/-   ##
==========================================
+ Coverage   24.37%   24.41%   +0.03%     
==========================================
  Files         442      443       +1     
  Lines       46902    46941      +39     
==========================================
+ Hits        11432    11459      +27     
- Misses      34560    34571      +11     
- Partials      910      911       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go 👍

@Warashi Warashi merged commit cbbd67d into master Oct 24, 2024
18 checks passed
@Warashi Warashi deleted the pipedv1-k8s-plugin-kustomize branch October 24, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants