-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event context #5295
Add event context #5295
Conversation
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
Signed-off-by: Yoshiki Fujikane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5295 +/- ##
==========================================
+ Coverage 24.37% 24.39% +0.01%
==========================================
Files 443 443
Lines 46927 46936 +9
==========================================
+ Hits 11439 11449 +10
+ Misses 34577 34576 -1
Partials 911 911 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
📝 The sample for how the GitHub shows the trailers
|
What this PR does:
Modified the pipectl event register command to allow adding metadata to events.
The metadata added to events will be included as trailers in commits created by the event watcher.
How to
Why we need it:
We want to check the source code links from the commits in the manifest repo.
Which issue(s) this PR fixes:
Part of #5028
Does this PR introduce a user-facing change?: