Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement calculating diff of kubernetes manifests #5298

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Oct 29, 2024

What this PR does:

as title

Why we need it:

When the K8s plugin determines the sync strategy, it must calculate which parts of the manifests are modified. This calculation is done by calculating the difference between the running deploy source and the target deploy source.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 77.04918% with 28 lines in your changes missing coverage. Please review.

Project coverage is 25.17%. Comparing base (c842a89) to head (afff927).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes/provider/diffutil.go 80.59% 10 Missing and 3 partials ⚠️
pkg/app/pipedv1/plugin/kubernetes/provider/diff.go 71.42% 8 Missing and 4 partials ⚠️
...app/pipedv1/plugin/kubernetes/provider/resource.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5298      +/-   ##
==========================================
+ Coverage   25.02%   25.17%   +0.14%     
==========================================
  Files         447      449       +2     
  Lines       47520    47642     +122     
==========================================
+ Hits        11892    11992     +100     
- Misses      34690    34705      +15     
- Partials      938      945       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit 8b49a84 into master Oct 30, 2024
18 checks passed
@Warashi Warashi deleted the pipedv1-k8s-plugin-diff branch October 30, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants