Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/form application piped v1 #5516

Merged
merged 13 commits into from
Feb 6, 2025
Merged

Conversation

hongky-1994
Copy link
Contributor

What this PR does:

  • Create Application form V1
  • Refactor Application Form V0 and Manual Form
  • Update logic AddApplicaitonm Drawer and Edit Application-drawer
  • Fix minor bugs:
    • Refetch application list when form is submit successfully.
    • Dupplicate Quit warning dialog.

Why we need it:

Which issue(s) this PR fixes:
Fixes #5509

Does this PR introduce a user-facing change?:
Yes

  • How are users affected by this change:
    • Now user will have 3 option to create an application
      • Piped v0 add from suggestion
      • Piped v1 add from suggestion
      • Add Manually

CleanShot 2025-01-28 at 00 20 45

  • Is this breaking change: No
  • How to migrate (if breaking change):

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.44%. Comparing base (edcf430) to head (568e542).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5516      +/-   ##
==========================================
+ Coverage   26.42%   26.44%   +0.02%     
==========================================
  Files         465      465              
  Lines       49858    49858              
==========================================
+ Hits        13175    13186      +11     
+ Misses      35629    35618      -11     
  Partials     1054     1054              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hongky-1994 hongky-1994 marked this pull request as ready for review February 3, 2025 17:30
@t-kikuc t-kikuc changed the title Feat/form application pipe v1 Feat/form application piped v1 Feb 4, 2025
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) February 6, 2025 01:49
@khanhtc1202 khanhtc1202 merged commit db1d74e into master Feb 6, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the feat/form-application-pipe-v1 branch February 6, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Form add and edit Application for piped v1
4 participants