Potential fix to Account IDs. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utilize longs instead of ints (Int32 vs Int64). The usage of ints (Int32) was what was causing the unhandled Newtonsoft.JsonReaderException. We may also want to consider updating Newtonsoft to 12.0.3 across each of the different projects.
|
LGTM, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General code cleanup as well as changing the AccountID properties to utilize longs instead of ints (Int32 vs Int64).
The usage of ints (Int32) was what was causing the unhandled Newtonsoft.JsonReaderException.
We may also want to consider updating Newtonsoft to 12.0.3 across each of the different projects.
This will address #3 here as well as #55 (pipe01/legendary-rune-maker#55) and #48 (pipe01/legendary-rune-maker#48)
List of items in this changeset: