Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded ci pipeline #27

Merged
merged 22 commits into from
Jan 28, 2025

Conversation

yoheinakajima
Copy link
Collaborator

Pull Request Template

Description

Expanded CI pipeline with new tests including testing web sockets, spinning up server, and testing onboarding form.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've run this as Github Actions in a fork i set up.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable):

Additional Notes:

Would be nice to expand this to test all UI, but making sure the server runs and one of the forms works feels like a good start :)

Copy link
Collaborator

@jcoleharrison jcoleharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and good to see tests being written. Would be good to continue to increase test coverage

@yoheinakajima yoheinakajima merged commit ef3ccd6 into pippinlovesyou:main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants