forked from hans/lwt
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A refreshed LWT #8
Open
HugoFara
wants to merge
1,169
commits into
pirtleshell:mine
Choose a base branch
from
HugoFara:master
base: mine
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h (not always).
…anguage rename (#113). JS Doc is added with JS DOC and PHP Doc with phpDocumentor. New global LWT_LANGUAGES_ARRAY. When renaming a language, text to speech was broken, it is fixed.
Some redundant/stupid code behavior fixed.
Fixed: some error notices are now displayed fully.
Fixes: audio position was not saved. Fixes: upload_words.php with $overwrite == 2 had missing escaping in SQL code. Fixes: set default translation on terms edit table. Fixes: avoid unwanted type conversion with |= Refactor: stricter types everywhere thanks to psalm.
* count quantities with mecab japanese * Update database_connect.php --------- Co-authored-by: Hugo <[email protected]>
New functions added.
Removes straight_join and edition of default values.
Simplifies workflow for new text insertion.
Adds todo_words_count, todo_words_content. Deprecates texttodocount2 in favor of todo_words_content. Removes texttodocount.
Updates logs.
…g database query).
The _migrations tables is now not prefixed, this is a hard-coded behavior.
…n, word status change. Updates composer lock file.
This is a behavior change and not a bug fix.
The install file now uses MariaDB by default.
Shorter names for unit tests.
psalm configuration was also updated to remove warnings.
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have been maintaining LWT for the last two months and I would like to push the latest LWT version. To sum up, I added the changes from the official LWT, as well as many refactors that make the code easier to maintain.
Here is a really brief summary:
do_text*.php
to stick much better to internet standards (reading on mobile and focus mode are now possible).If you want a more in-depth view on my philosophy I wrote the What is happening to LWT? post. Simply put, I just focused on the better integration of current features.
As they are important security fixes (insecure shell accesses and inconsistencies in the call stack), I think you should pull this commit. For next commits I will focus on new features, please tell me if there is something you want to see!
By the way, this pull request "solves" the issue #7 , LWT is not dead ;)