Rewrite library module tests to use mocked inputs #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite tests/library_test.py to use mocked HTTP requests instead of calling module functions directly and making real HTTP requests (see issue #166). The mocked JSON response is stored in the newly added file tests/samples/library_mock_response_water.json. This commit also fixes a heretofore unnoticed bug in the library URL, where the URL accidentally contains newline characters due to a triple-quoted string being used instead of a single- or double-quoted string.
|
All tests pass even after I reenabled the library module tests for GitHub. |
nij-patel
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #166
Rewrite
tests/library_test.pyto use mocked HTTP requests instead of calling module functions directly and making real HTTP requests (see #166). I deleted the tests for the library bookmark functions, since the code makes it clear that the new library API doesn't support bookmarks anyway. I ran pytest locally, and there appear to be no more errors with the library tests.I also fixed a heretofore unnoticed bug in the library URL, where the URL accidentally contains newline characters due to a triple-quoted string being used instead of a single- or double-quoted string.