Convert gym unit test mock from Python str to HTML
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the mock for gym unit tests from a Python string to an HTML file. This makes the mocking of gym unit tests more consistent with how unit tests for other modules are mocked. This also avoids unnecessarily mocking entire module functions, as only the HTTP requests made by those functions need to be mocked. Since the mock is only supposed to contain an HTML HTTP response, it makes more sense to keep it as HTML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the mock for
gymunit tests from a Python string to an HTML file. This makes the mocking ofgymunit tests more consistent with how unit tests for other modules are mocked. This also avoids unnecessarily mocking entire module functions, as only the HTTP requests made by those functions need to be mocked. Since the mock is only supposed to contain an HTML HTTP response, it makes more sense to keep it as HTML.I placed the new HTML mock in the
tests/samples/directory rather than thetests/mocks/directory where the current mock is located. I'm doing this as part of a larger effort to migrate all the mocks intests/mocks/totests/samplesso that mocks won't be split across two sibling directories.