Add setup #286
Closed
Add setup #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2021 16:57
- Break into base_setup and add_setup so that additional items can be installed later - Changed MY_DIR to more descriptive WORKSTATION_SETUP_HOME - Use up-to-date 'brew install --cask' syntax
ericadohring
reviewed
Feb 1, 2021
| brew install --cask zoomus | ||
|
|
||
| source ${WORKSTATION_SETUP_HOME}/scripts/common/zprofile-setup.sh | ||
| source ${WORKSTATION_SETUP_HOME}/scripts/common/asdf.sh |
There was a problem hiding this comment.
Could you remove zprofile-setup.sh and asdf.sh? Neither of these are in your PR nor our current repo.
ericadohring
reviewed
Feb 1, 2021
| source ${WORKSTATION_SETUP_HOME}/scripts/common/unix.sh | ||
| source ${WORKSTATION_SETUP_HOME}/scripts/common/configuration-osx.sh | ||
| source ${WORKSTATION_SETUP_HOME}/scripts/common/configurations.sh | ||
| source ${WORKSTATION_SETUP_HOME}/scripts/common/redis.sh |
There was a problem hiding this comment.
Could you remove redis.sh? We don't have this file either.
ericadohring
reviewed
Feb 1, 2021
| @@ -1,4 +1,4 @@ | |||
| echo | |||
| echo "Installing dotnet requirements" | |||
| brew install --cask dotnet dotnet-sdk | |||
| source ${MY_DIR}/scripts/opt-in/dotnet-tools.sh | |||
| source ${WORKSTATION_SETUP_HOME}/scripts/opt-in/dotnet-tools.sh | |||
There was a problem hiding this comment.
👍 for this name change.
|
We are declaring PR bankruptcy as per #295. Please review recent changes and direction and resubmit if needed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We customized workstation-setup for use at my new company and found that we wanted to be able to update older workstations by adding new tools. Seems like this addition would be useful for more than just us.