Fix tests and add lint and test workflows

[andrecsilva]

Fixes the current tests and adds an environment in which they can succeed.

• Adds a test workflow.
• Fix tests so they can actually succeed in the workflow.
• Updates linting workflow to be a bit more strict.
• Adds a urlopen version for the safe_requests api.

[clavedeluna]

I think you copied quite a bit of this and none of these locations exist in this repo, same for the other excludes, the mypy typing mocks that we may not be using

[clavedeluna]

It's hard to know what's part of the PR to "fix tests", what's urlopen, and what was just linting. Can you explain Fix tests so they can actually succeed in the workflow.? so it's more clear? what were the issues?

[andrecsilva]

It's hard to know what's part of the PR to "fix tests", what's urlopen, and what was just linting. Can you explain Fix tests so they can actually succeed in the workflow.? so it's more clear? what were the issues?

The title is fairly descriptive of what this PR addresses.

Tests were failing and would fail in any machine for a myriad of reasons. Those range from not having netcat installed, not using a shell with brace expansion, permission issues, and many others. We didn't have any workflow for running tests for PRs, so those tests were merged into main while faulty. You're free to try to run them yourself and check the results.

This PR fixes those issues and adds a workflow to run those tests while preserving the intent of the original tests as much as possible. The workflow will help make sure we don't merge problematic tests/code again. I've also added a linting step to the workflow make sure the code is kept to a good standard in the future.

Before running into tests issues, my original with this branch was to add a version of safe_requests that uses urllib.request.urlopen instead of requests.get. We can't directly translate urlopen calls to requests.get due to some parameters of the former. This was included as well.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud