Skip to content

Commit

Permalink
Use default excludes to have the same behavior as starlark filter
Browse files Browse the repository at this point in the history
Signed-off-by: Dom Del Nano <[email protected]>
  • Loading branch information
ddelnano committed Sep 4, 2024
1 parent 6c2dcbd commit 16676bc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
4 changes: 3 additions & 1 deletion ci/bazel_build_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,10 @@ commit_range=$(git merge-base origin/main HEAD)
bpf_excludes="except attr('tags', 'requires_bpf', //...)"
go_xcompile_excludes="except //src/pixie_cli:px_darwin_amd64 except //src/pixie_cli:px_darwin_arm64"
buildables_excludes="except(kind(test, //...)) except(kind(container_image, //...))"
# gazelle_lib is tagged with manual, but isn't caught by the attr filter
# https://github.com/bazelbuild/bazel-gazelle/issues/1742
default_excludes="except attr('tags', 'manual|disabled_flaky_test', //...) \
except //third_party/..."
except //third_party/... except @bazel_gazelle//cmd/gazelle:gazelle_lib"

sanitizer_only="except attr('tags', 'no_asan', //...) \
except attr('tags', 'no_msan', //...) \
Expand Down
3 changes: 0 additions & 3 deletions ci/cquery_ignore_non_target_and_incompatible.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
# SPDX-License-Identifier: Apache-2.0

def format(target):
if target.label.name.endswith("//cmd/gazelle:gazelle_lib"):
return None

build_opts = build_options(target)

# We only want to get targets that are in the target configuration. So we ignore exec and host targets.
Expand Down

0 comments on commit 16676bc

Please sign in to comment.