Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use fpm binary from within dev_image_extras container for cli releases (
#2015) Summary: Use fpm binary from within dev_image_extras container for cli releases With #2012 merged, the `dev_image_with_extras` container image now contains `fpm`. This change removes the use of podman to avoid the permission issues seen in recent cli builds. This should allow the production cli release build to succeed. Relevant Issues: Closes #1993 Type of change: /kind bugfix Test Plan: Verified that `fpm` exists in most recent image and packaging building commands work (see testing on #2012). Running a production cli release build is needed after this is merged to complete the testing. ``` $ ./scripts/run_docker.sh sha256:c14b06e5753d4d9c6b2ff8671843043113cdcfa3f3cb36a492a665d71dc42fad grep: /etc/bazelrc: No such file or directory Run Parameters: Build Buddy: Disabled Shell: /bin/bash + docker run --rm --hostname px-dev-docker-dev-vm.us-west1-a.c.endless-datum-422018.internal -it -v /dev/shm:/dev/shm -v /home/ddelnano:/home/ddelnano -v /var/run/docker.sock:/var/run/docker.sock -v /home/ddelnano/code/pixie-worktree:/px/src/px.dev/pixie --network=host -v /usr/local/bin/px:/bin/px px_dev_image:202409092344 /bin/bash ddelnano@px-dev-docker-dev-vm:/px/src/px.dev/pixie (ddelnano/use-fpm-within-dev_image_extras-container) $ fpm --version 1.15.1 ``` Signed-off-by: Dom Del Nano <[email protected]>
- Loading branch information