Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Restore ability to disable tracing for protocols via PEM flags (#1669)
Summary: Restores ability to disable tracing of specific protocols via PEM flags (i.e. environment variable injection). Also changes the flag name listed in the [docs](https://docs.px.dev/reference/admin/deploy-options#set-a-pem-flag) for backwards compatibility, as a previously defined PEM flag could cause a type error. Disabling specific protocols from tracing is requested by end users (e.g. for optimizing memory usage) and often useful when debugging (or side stepping) PEM bugs. Related issues: Fixes #1614 Type of change: /kind feature Related documentation change: pixie-io/docs.px.dev#274 Test Plan: Verified that tracing is still on by default for each protocol and that tracing still runs as expected via the `socket_tracer` tests. A further test is required to ensure that the enum `TraceMode::OnForNewerKernel` is set correctly for `mux` tracing in older kernels. Due to permission issues, I can't currently run this `QEMU` test: ``` bazel test -c opt --config=qemu-bpf --test_output=all --cache_test_results=no --remote_download_outputs=all //src/stirling/source_connectors/socket_tracer:mux_trace_bpf_test --test_output=streamed --//bazel/test_runners/qemu_with_kernel:kernel_version=oldest ``` Signed-off-by: Benjamin Kilimnik <[email protected]>
- Loading branch information