Merge pull request #703 from pixiv/fix/github-actions-storybook-build

chore: fix storybook build action

.github/workflows/gh-pages.yml

@@ -13,13 +13,13 @@ jobs:
 
     steps:
       - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v4
+        with:
+          version: '10.4.0'
       - uses: actions/setup-node@v3
         with:
           node-version-file: '.node-version'
           cache: pnpm
-      - uses: pnpm/action-setup@v4
-        with:
-          version: '10.4.0'
 
       - name: Prepare deps
         run: |

.github/workflows/test-storybook.yml

@@ -122,12 +122,18 @@ jobs:
         with:
           name: base__image-snapshots__
           path: __image_snapshots__/
+      - name: Verify Storybook server can start
+        run: |
+          pnpm http-server storybook-static --port 6006 --silent &
+          PID=$!
+          pnpm wait-on -t 60000 tcp:127.0.0.1:6006
+          kill $PID
       - name: Serve Storybook and run tests
         if: steps.label-checking.outputs.result != 'true'
-        run: pnpm test:image-snapshot
+        run: pnpm test:image-snapshot:ci
       - name: Serve Storybook and take new image snapshots
         if: steps.label-checking.outputs.result == 'true'
-        run: pnpm test:image-snapshot --updateSnapshot
+        run: pnpm test:image-snapshot:ci --updateSnapshot
       - name: Archive image snapshot diffs
         uses: actions/upload-artifact@v4
         if: failure() && steps.label-checking.outputs.result != 'true'

package.json

@@ -15,8 +15,9 @@
     "build": "pnpm -r --sort --workspace-concurrency=Infinite --stream run build",
     "clean": "pnpm -r --workspace-concurrency=Infinity --stream run clean",
     "test": "vitest",
-    "test:image-snapshot": "TEST_RUNNER=vrt concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on tcp:127.0.0.1:6006 && test-storybook ${*}\"",
-    "test:a11y": "TEST_RUNNER=a11y concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on tcp:127.0.0.1:6006 && test-storybook ${*}\"",
+    "test:image-snapshot": "TEST_RUNNER=vrt concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on -t 30000 tcp:127.0.0.1:6006 && test-storybook --maxWorkers=2 ${*}\"",
+    "test:image-snapshot:ci": "TEST_RUNNER=vrt concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on -t 60000 tcp:127.0.0.1:6006 && test-storybook --maxWorkers=1 --timeout=60000 ${*}\"",
+    "test:a11y": "TEST_RUNNER=a11y concurrently -k -s first -n \"SB,TEST\" -c \"magenta,blue\" \"http-server storybook-static --port 6006 --silent\" \"wait-on -t 30000 tcp:127.0.0.1:6006 && test-storybook ${*}\"",
     "typecheck": "pnpm recursive run typecheck",
     "typecheck:config": "tsc",
     "lint": "run-p 'lint:*'",