fix: Normalized bones now respect non humanoid parent rotations #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ke456-png
reviewed
Jan 18, 2024
Comment on lines
-57
to
-65
| let parentWorldPosition: THREE.Vector3 | undefined; | ||
| let parentWorldRotation: THREE.Quaternion | undefined; | ||
| while (parentWorldPosition == null) { | ||
| let parentBoneWorldPosition: THREE.Vector3 | undefined; | ||
| while (parentBoneWorldPosition == null) { | ||
| currentBoneName = VRMHumanBoneParentMap[currentBoneName]; | ||
| if (currentBoneName == null) { | ||
| break; | ||
| } | ||
| parentWorldPosition = boneWorldPositions[currentBoneName]; | ||
| parentWorldRotation = boneWorldRotations[currentBoneName]; |
There was a problem hiding this comment.
[memo]: VRMHumanBoneParentMap was used to reference a rotation of the parent bone, which was problematic when the parent was a non-humanoid bone with rotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalized bones now respect non humanoid parent rotations.
When the humanoid bone hierarchy has non-humanoid bones with rotation (e.g., hips have a parent node with rotation), normalized bones don't work properly.
This commit will fix this.