Bump Three.js to r162 #1379
Merged
Bump Three.js to r162 #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a lot of build errors right now It seems most of them come from the change that @types/three no longer expose THREE to global (and I somehow forgot to import in many files!)
|
Migration Guide
This change does not affect mtoon and tests are also ok. |
yue4u
reviewed
Mar 7, 2024
| @@ -1,3 +1,4 @@ | |||
| import type * as THREE from 'three'; | |||
There was a problem hiding this comment.
This can also be done as import { type Group } from 'three'; but requires more changes overall. I'm ok with current approach.
yue4u
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps Three.js to r162.
See: https://github.com/mrdoob/three.js/releases/tag/r162
@types/threeno longer expose THREE to global and I somehow forgot to import the types in many files, so I fixed it also.