Add functional options to allow configuring the underlying Cmd #30
+45
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
browser
exposes theStdout
andStderr
vars for consuming packages to control where its output goes. This global state serves most purposes, but doesn't suffice if a project wants different output destinations for differentOpenURL
calls.Solution
Add options to the
Open*
functions to allow the user to configure the command's stdout and stderr.Notes
CmdOption
, so maybe it'd make more sense to just define an OpenOption type that just has stdout/stderr and keepexec.Command
out of the API.GOOS=windows
. It looks like they should have been included in Windows: utilize ShellExecuteW #27. If you'd like, I'm happy to put them up as a separate PR since they're not really part of this change, or they're also taken care of by Fix running project on Windows #29, if that ever gets merged.