Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for macOS by using shims (feature branch) #141

Open
wants to merge 52 commits into
base: feature/macOS
Choose a base branch
from
Open

Adding support for macOS by using shims (feature branch) #141

wants to merge 52 commits into from

Conversation

Fab1n
Copy link

@Fab1n Fab1n commented Feb 24, 2017

Same as #137. Now into feature branch.

Fabian Renner added 6 commits February 8, 2017 16:07
Adds support for macOS.
23276c0 
This allows PKHUD to be used across iOS and macOS

Note: WindowRootViewController has been dropped, as it is not used anymore.
Fixes the glitches of rounded corners on a VisualEffectView
3a8e7d3 
On macOS showing a hud in a window sheet lead to black corners where the VisualEffectView should have transparent rounded corners
removing hitTest override for macOS as it is not working anyway
5d5f89a
Fix closing path issue for macOS
701a49c
Fixes hidden system activity indicator on mac
cd003f0
change blending mode depending on using 10.11 or 10.12
2f5e970
@Fab1n Fab1n mentioned this pull request Feb 24, 2017
Closed
@PGLongo
Copy link
Collaborator

PGLongo commented Feb 24, 2017

I've only tried the demo and I think:

  1. Show and disappear animation is not smooth enough as the iOS version
  2. The background of the HUD is not blurred as should be
  3. If I click a success and on disappear I click error the animation is broken (have a look to the GIF)
  4. The title's margin top of the HUD should be increased
  5. The title's margin bottom of the HUD should be decreased

ezgif-2-df10855bee

@PGLongo
Copy link
Collaborator

PGLongo commented Mar 29, 2017

@Fab1n any news?

RoCry and others added 25 commits June 6, 2017 13:33
@RoCry
Fix add subview to UIVisualEffectView
b1093ba
@PGLongo
Merge pull request #169 from RoCry/master
8143ac8 
Fix add subview to UIVisualEffectView
@PGLongo
Merge pull request #168 from pkluz/graceTime-improvement
99b0cb4 
Add gracePeriod and deprecated graceTime
@PGLongo
Updated README.md with Swift4 branch
ef8c46d
@PGLongo
Bump version to 4.2.3
36c0fe2
@PGLongo
Update iOS 10 destination to 10.3
bef39d3
@PGLongo
Add pod lib lint in .travis
1273c2f
@PGLongo
Replace iPhone 7 Plus with iPhone 7 in .travis
4360790
@thibauddavid
Exposing old objc API methods using #selector to @objc
852423e
@PGLongo
Merge pull request #175 from thibauddavid/release/swift4
3fb1f53 
Exposing old objc API methods using #selector to @objc
Update project to Xcode 9 beta 5
4d8fbf7
@RoCry @angerman
Fix add subview to UIVisualEffectView
21fc6de
@PGLongo
Merge pull request #199 from pkluz/release/swift4
69fa94c 
Add Swift4 support
@dankimio
Re-indent Ruby code in README.md
b1788ae
@PGLongo
Merge pull request #204 from dankimio/patch-1
b043459 
Re-indent Ruby code in README.md
Upgrade travis to xcode9
38a1abb
Update iOS SDK in .travis.yml
b4d5d54
Add iOS11 support in .travis
a1acaf3
Add .swift-version
dfadd0c
@PGLongo
Merge pull request #206 from pkluz/travis-upgrade
79a88a2 
Travis upgrade
Update readme for swift4 support
5c22c59
Fix style with SwiftLint
8cb1192
Update Gemfile
4f98d2d
Update to version 5.0.0
492f82b
Merge branch 'version5.0' into macOSBasedOn4.2.0
3bfd247 
# Conflicts:
#	PKHUD.podspec
#	PKHUD/PKHUD.swift
#	PKHUD/Window.swift
@LukasGram LukasGram deleted the macOSBasedOn4.2.0 branch July 20, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Fab1n @PGLongo @nkanellopoulos @Piyush08 @LaurentiuUngur @Veronique @RoCry @thibauddavid @dankimio