fix: do not check action is valid when append block

planetarium · Oct 22, 2024 · 247f07c · 247f07c
1 parent 57a4569
commit 247f07c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 64 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -18,13 +18,19 @@ To be released.
 
 ### Behavioral changes
 
+ -  There is no longer a check at block validation time to see
+    if the actions contained in a block are interpretable. [[#3972]]
+
 ### Bug fixes
 
 ### Dependencies
 
 ### CLI tools
 
 
+[#3972]: https://github.com/planetarium/libplanet/pull/3972
+
+
 Version 5.3.1
 -------------
 

diff --git a/src/Libplanet/Blockchain/BlockChain.Validate.cs b/src/Libplanet/Blockchain/BlockChain.Validate.cs
@@ -4,7 +4,6 @@
 using System.Linq;
 using System.Numerics;
 using System.Security.Cryptography;
-using Bencodex.Types;
 using Libplanet.Action;
 using Libplanet.Action.State;
 using Libplanet.Common;
@@ -199,17 +198,6 @@ internal Dictionary<Address, long> ValidateBlockNonces(
             return nonceDeltas;
         }
 
-        internal void ValidateBlockLoadActions(Block block)
-        {
-            foreach (Transaction tx in block.Transactions)
-            {
-                foreach (IValue rawAction in tx.Actions)
-                {
-                    _ = ActionEvaluator.ActionLoader.LoadAction(block.Index, rawAction);
-                }
-            }
-        }
-
         internal void ValidateBlock(Block block)
         {
             if (block.Index <= 0)

diff --git a/src/Libplanet/Blockchain/BlockChain.cs b/src/Libplanet/Blockchain/BlockChain.cs
@@ -813,8 +813,6 @@ internal void Append(
                         .ToDictionary(signer => signer, signer => Store.GetTxNonce(Id, signer)),
                     block);
 
-                ValidateBlockLoadActions(block);
-
                 if (Policy.ValidateNextBlock(this, block) is { } bpve)
                 {
                     throw bpve;

diff --git a/test/Libplanet.Tests/Blockchain/BlockChainTest.Append.cs b/test/Libplanet.Tests/Blockchain/BlockChainTest.Append.cs
@@ -651,56 +651,6 @@ void AssertTxIdSetEqual(
                 _blockChain.StagePolicy.Iterate(_blockChain, filtered: false).Select(tx => tx.Id));
         }
 
-        [SkippableFact]
-        public void CannotAppendBlockWithInvalidActions()
-        {
-            var txSigner = new PrivateKey();
-            var unsignedInvalidTx = new UnsignedTx(
-                new TxInvoice(
-                    _blockChain.Genesis.Hash,
-                    DateTimeOffset.UtcNow,
-                    new TxActionList((IValue)List.Empty.Add(new Text("Foo")))), // Invalid action
-                new TxSigningMetadata(txSigner.PublicKey, 1));
-            var invalidTx = new Transaction(
-                unsignedInvalidTx, unsignedInvalidTx.CreateSignature(txSigner));
-            var txs = new[]
-            {
-                Transaction.Create(
-                    nonce: 0,
-                    privateKey: txSigner,
-                    genesisHash: _blockChain.Genesis.Hash,
-                    actions: Array.Empty<DumbAction>().ToPlainValues()),
-                invalidTx,
-                Transaction.Create(
-                    nonce: 2,
-                    privateKey: txSigner,
-                    genesisHash: _blockChain.Genesis.Hash,
-                    actions: Array.Empty<DumbAction>().ToPlainValues()),
-            }.OrderBy(tx => tx.Id);
-            var evs = Array.Empty<EvidenceBase>();
-
-            var metadata = new BlockMetadata(
-                index: 1L,
-                timestamp: DateTimeOffset.UtcNow,
-                publicKey: _fx.Proposer.PublicKey,
-                previousHash: _blockChain.Genesis.Hash,
-                txHash: BlockContent.DeriveTxHash(txs),
-                lastCommit: null,
-                evidenceHash: null);
-            var preEval = new PreEvaluationBlock(
-                preEvaluationBlockHeader: new PreEvaluationBlockHeader(
-                    metadata, metadata.DerivePreEvaluationHash()),
-                transactions: txs,
-                evidence: evs);
-            var block = preEval.Sign(
-                _fx.Proposer,
-                (HashDigest<SHA256>)_blockChain.GetNextStateRootHash(_blockChain.Tip.Hash));
-
-            Assert.Throws<InvalidActionException>(
-                () => _blockChain.Append(block, TestUtils.CreateBlockCommit(block)));
-            Assert.Equal(0, _blockChain.Tip.Index);
-        }
-
         [SkippableFact]
         public void DoesNotMigrateStateWithoutAction()
         {