Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm build bug #3460

Closed
wants to merge 5 commits into from
Closed

Fix npm build bug #3460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
330ff7b
Revert "fix import mjs to require cjs (#3459)"
XxshiftxX Oct 27, 2023
ad29ab2
DONT MERGE
moreal Oct 27, 2023
4cd5ca2
Use Nodejs 18
moreal Oct 28, 2023
88fc21e
Revert "Revert "fix import mjs to require cjs (#3459)""
XxshiftxX Oct 30, 2023
44fba85
Merge branch 'rollback-fix-mjs-to-cjs' of https://github.com/planetar…
XxshiftxX Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/bin/constants.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,5 @@ if [ "$GITHUB_REPOSITORY" = "planetarium/libplanet" ] && [[ \
]]; then
publish_package=true
fi

publish_package=false
3 changes: 2 additions & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
push:
branches:
- "main"
- "rollback-fix-mjs-to-cjs"
tags:
- "*"
name: Build artifact and push
Expand Down Expand Up @@ -39,7 +40,7 @@ jobs:
with:
registry-url: 'https://registry.npmjs.org'
scope: '@planetarium'
node-version: 'lts/*'
node-version: 18
- id: determine-version
run: node scripts/determine-version.js
- shell: bash
Expand Down
Loading