💥 Deprecate PoW evaluation #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greymistcube
force-pushed
the
refactor/deprecate-pow-evaluation
branch
4 times, most recently
from
f992c5b
to
57c9b77
Compare
greymistcube
force-pushed
the
refactor/deprecate-pow-evaluation
branch
from
57c9b77
to
53432b0
Compare
greymistcube
force-pushed
the
refactor/deprecate-pow-evaluation
branch
from
53432b0
to
25bc5f2
Compare
greymistcube
force-pushed
the
refactor/deprecate-pow-evaluation
branch
from
25bc5f2
to
a678e77
Compare
riemannulus
reviewed
May 22, 2024
|
Could you make sure to succeed Details? |
@riemannulus |
riemannulus
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3790.
See the changelog for the ramification for deprecating PoW evaluation.
Further API fixes will be in subsequent PRs. These include
IActionContexttyped parameter fromIWorld.TransferAsset()IWorldwithIWorld.Versionless thanBlockMetadata.PBFTProtocolVersionand possibly more as they come up. 😶