fix System.NullReferenceException in BaseActionHandler

planetarium · Oct 29, 2024 · f669876 · f669876
1 parent 6ec46f0
commit f669876
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Mimir.Worker/ActionHandler/BaseActionHandler.cs b/Mimir.Worker/ActionHandler/BaseActionHandler.cs
@@ -137,7 +137,7 @@ private async Task ProcessTransactions(
         var txsResponse = await FetchTransactionsAsync(syncedBlockIndex, limit, cancellationToken);
 
         var blockIndex = syncedBlockIndex + limit;
-        Logger.Information("GetTransaction Success, tx-count: {TxCount}", txsResponse.NCTransactions.Count);
+        Logger.Information("GetTransaction Success, tx-count: {TxCount}", txsResponse.NCTransactions?.Count ?? 0);
         await HandleTransactionsAsync(
             blockIndex,
             txsResponse,
@@ -190,7 +190,7 @@ private async Task HandleTransactionsAsync(
         TransactionResponse transactionResponse,
         CancellationToken cancellationToken)
     {
-        var tuples = transactionResponse.NCTransactions
+        var tuples = transactionResponse.NCTransactions?
             .Where(tx => tx is not null)
             .Select(tx =>
                 (
@@ -202,7 +202,7 @@ private async Task HandleTransactionsAsync(
                         .ToList()
                 )
             )
-            .ToList();
+            .ToList() ?? [];
 
         var documents = new List<WriteModel<BsonDocument>>();
         foreach (var (txId, signer, actions) in tuples)

diff --git a/Mimir.Worker/Client/Models.cs b/Mimir.Worker/Client/Models.cs
@@ -68,7 +68,7 @@ public class GetTransactionsResponse
 public class TransactionResponse
 {
     [JsonPropertyName("ncTransactions")]
-    public List<NcTransaction?> NCTransactions { get; set; }
+    public List<NcTransaction?>? NCTransactions { get; set; }
 }
 
 public class NcTransaction