-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huge work; Run TxPoller in parallel #403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreal
force-pushed
the
txpoller-parallel
branch
from
October 18, 2024 13:10
15da932
to
1dfb751
Compare
moreal
force-pushed
the
txpoller-parallel
branch
from
October 22, 2024 17:04
e2c21e1
to
761a31b
Compare
moreal
changed the title
Do not decode plainValue to action type
Huge work; Run TxPoller in parallel
Oct 22, 2024
boscohyun
approved these changes
Oct 23, 2024
Atralupus
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MTGL
Closed
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This pull request is too huge to review. 😭 Please read this comment as well before looking around the code. 🙏🏻
Overview
I started to work on this pull request to make handlers in
TxPoller
run in parallel. But this pull request becomes to include many changes:BackgroundService
. (even for handlers inDiffPoller
).DiffPoller
,DiffProducer
andDiffConsumer
has removed. Their functions are moved toBaseDiffHandler
.TxPoller
run in parallel, so they updates eachMetadataDocument
themselves.BackgroundService
Worker
executed initializers but initializers will run asBackgroundService
.Task IInitializerManager.WaitInitializers(CancellationToken)
method.BaseDiffHandler
andBaseActionHandler
receivesIInitializerManager
instance as dependency and call it before looping its logic.TableSheetInitializer
should be run beforeArenaIntializer
. SoArenaInitializer
receives it as dependency, and wait untilTableSheetInitializer.ExecuteTask
is completed....Handler
have been renamed to...StateDocumentConverter
.PlanetType
became enum type.Next step