Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge work; Run TxPoller in parallel #403

Merged
merged 26 commits into from
Oct 23, 2024
Merged

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Oct 18, 2024

Warning

This pull request is too huge to review. 😭 Please read this comment as well before looking around the code. 🙏🏻

Overview

I started to work on this pull request to make handlers in TxPoller run in parallel. But this pull request becomes to include many changes:

  • All handlers become an independent BackgroundService. (even for handlers in DiffPoller).
    • DiffPoller, DiffProducer and DiffConsumer has removed. Their functions are moved to BaseDiffHandler.
    • All handlers in TxPoller run in parallel, so they updates each MetadataDocument themselves.
  • All initializers become an independent BackgroundService
    • Originally, Worker executed initializers but initializers will run as BackgroundService.
    • To wait until the initializers complete their job, it introduces Task IInitializerManager.WaitInitializers(CancellationToken) method. BaseDiffHandler and BaseActionHandler receives IInitializerManager instance as dependency and call it before looping its logic.
    • Also TableSheetInitializer should be run before ArenaIntializer. So ArenaInitializer receives it as dependency, and wait until TableSheetInitializer.ExecuteTask is completed.
  • Diff-based handlers previously called ...Handler have been renamed to ...StateDocumentConverter.
  • PlanetType became enum type.

Next step

  • Configure handlers to run.
  • Update Assertible to check metadata for each collection.

@moreal moreal changed the title Do not decode plainValue to action type Huge work; Run TxPoller in parallel Oct 22, 2024
@moreal moreal marked this pull request as ready for review October 22, 2024 17:23
@moreal moreal added this pull request to the merge queue Oct 23, 2024
Copy link
Member

@Atralupus Atralupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MTGL

Merged via the queue into planetarium:main with commit 3515b3e Oct 23, 2024
7 checks passed
@Atralupus Atralupus mentioned this pull request Oct 23, 2024
This was referenced Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants