Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless codes that relates to RuneSlotState #407

Merged
merged 1 commit into from
Oct 31, 2024
Merged

remove useless codes that relates to RuneSlotState #407

merged 1 commit into from
Oct 31, 2024

Conversation

umardevX
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

moreal
moreal approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to me. @boscohyun Could you review this PR?

@moreal moreal linked an issue Oct 22, 2024 that may be closed by this pull request
remove useless codes that relates to RuneSlotState #391
Closed
4 tasks
@boscohyun
Copy link
Member

@umardevX We can remove more types:

  • RuneSlotDocument
  • RuneSlotCollectionUpdater
  • RuneSlotStateHandler

And there may be more types.

@umardevX
Copy link
Contributor Author

@boscohyun can you please create a separate issue for other removal stuff.

@boscohyun
Copy link
Member

boscohyun commented Oct 25, 2024 •
edited
Loading

@umardevX The goal of issue #391 is to remove all useless code related to RuneSlotState.

@moreal moreal self-requested a review October 25, 2024 02:52
@moreal moreal mentioned this pull request Oct 31, 2024
Closed
4 tasks
@moreal moreal added this pull request to the merge queue Oct 31, 2024
Merged via the queue into planetarium:main with commit 188d2b4 Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atralupus Atralupus Awaiting requested review from Atralupus

@boscohyun boscohyun Awaiting requested review from boscohyun

@moreal moreal Awaiting requested review from moreal

Assignees

@umardevX umardevX

Labels
None yet
Projects
Planetarium open-source contributor
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove useless codes that relates to RuneSlotState
4 participants
@umardevX @CLAassistant @boscohyun @moreal