Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce several balance APIs #70

Merged
merged 16 commits into from
May 21, 2024
Merged

feat: introduce several balance APIs #70

merged 16 commits into from
May 21, 2024

Conversation

boscohyun
Copy link
Member

@boscohyun boscohyun commented May 21, 2024 •
edited
Loading

  • Introduce Models.Assets.Balance
  • Introduce Validators.AddressValidator
  • Introduce "{network}/agent/{address}/balances"
  • Introduce BalanceController with "{network}/balances/{address}/{currency}"

@boscohyun boscohyun self-assigned this May 21, 2024
@boscohyun boscohyun marked this pull request as ready for review May 21, 2024 04:02
@boscohyun boscohyun requested review from moreal, Atralupus and a team May 21, 2024 04:02
@Atralupus
Copy link
Member

When we apply storing balance data in the Mimir worker, will the balance data come from the database?

@boscohyun boscohyun mentioned this pull request May 21, 2024
Merged
@boscohyun
Copy link
Member Author

When we apply storing balance data in the Mimir worker, will the balance data come from the database?

Yes it is!

@boscohyun boscohyun merged commit 96a152b into main May 21, 2024
3 checks passed
@boscohyun boscohyun deleted the feat/balance branch May 21, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atralupus Atralupus Atralupus approved these changes

@moreal moreal Awaiting requested review from moreal

Assignees

@boscohyun boscohyun

Labels
None yet
Projects
Nine Chronicles DX Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boscohyun @Atralupus