Add vanish_requests stream subscriber #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11404435878Details
💛 - Coveralls |
mplorentz
approved these changes
Oct 17, 2024
|
|
||
| info!("Removed public key {} from vanish request", public_key.to_hex()); | ||
|
|
||
| last_id = stream_id.id.clone(); |
There was a problem hiding this comment.
Does this get stored somewhere other than memory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of https://github.com/planetary-social/infrastructure/issues/139
Subscribes to the vanish_subscriber stream so we can drop pubkey nodes and their relationships. It also updates the cached counters.
Notice we still would need to add some state to all the subscribers of this stream to avoid accepting republications. We can always restart the processing of the vanish requests from the beginning periodically as a quick cleanup but this will need to be implemented at another moment to be able to hit the deadline.
This was manually tested sucessfully, with more time I'd like to add some tests.