ObservableObject to @Observable migrations #1458 #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
bryanmontz
commented
Oct 19, 2024
| @Dependency(\.analytics) private var analytics | ||
| @Dependency(\.crashReporting) private var crashReporting | ||
| @MainActor @Dependency(\.currentUser) private var currentUser | ||
| @Published var numberOfConnectedRelays: Int = 0 |
There was a problem hiding this comment.
This property wasn't being used anywhere.
joshuatbrown
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Everything looks good to me and works fine. I might still suggest having @mplorentz review since our release is coming up soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#1458
Description
Migrates several more classes to use
@Observablemacro rather than theObservableObjectprotocol for the performance gains and general modernization of patterns.How to test
Navigate to the Note Composer view.
Tap "@" to bring up the user search view.
Observe that the search fires on key taps.
Navigate to the Note Composer.
Type a note.
Send it.
Observe that the note was sent.
Navigate to the Discover tab.
Search for something.
Observe that results appear as you type.
Navigate to your profile view.
Tap the Claim your username button.
Select either set up or already have.
Type in the box.
Observe that the UI responds as you type.
Screenshots/Video
No intended UI changes, but here are some videos of affected areas of code to show that they still work as expected:
Adding a mention to a note...(shows that the refactored
TextDebouncerworks)Posting a note...(shows that
RelayServiceas@Observableworks)Search in Discover...(shows that
SearchControlleras@Observableworks)Username search...(shows that
SearchControllerandTextDebouncerwork)