Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to inotify_simple from unsupported pyinotify #91

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Move to inotify_simple from unsupported pyinotify #91

merged 2 commits into from
Jul 3, 2024

Conversation

oldpatricka
Copy link
Contributor

@oldpatricka oldpatricka commented Jul 2, 2024 •
edited
Loading

This PR makes a few changes to better support Python 3.12+

  • Move from unsupported (and not working with Python 3.12) pyinotify to inotify_simple, which has no dependencies aside from inotify itself
  • Move from versioneer to versioningit
  • Move from setup.py to pyproject.toml
  • move from setup.py dist to build
  • Fix CI to actually run queueable tests

@oldpatricka oldpatricka force-pushed the move-to-inotify-simple branch 3 times, most recently from 5ad2a34 to f428ea6 Compare July 2, 2024 22:54
@oldpatricka oldpatricka force-pushed the move-to-inotify-simple branch 4 times, most recently from 5b0d333 to 4bcfc6c Compare July 3, 2024 15:36
@oldpatricka oldpatricka changed the title Draft: Move to inotify_simple from unsupported pyinotify Move to inotify_simple from unsupported pyinotify Jul 3, 2024
@oldpatricka oldpatricka requested a review from bcavagnolo July 3, 2024 15:56
@oldpatricka oldpatricka marked this pull request as ready for review July 3, 2024 15:56
@oldpatricka oldpatricka force-pushed the move-to-inotify-simple branch from 4bcfc6c to 86b8124 Compare July 3, 2024 16:05
@bcavagnolo bcavagnolo merged commit 45c556a into planetlabs:master Jul 3, 2024
9 checks passed
@bcavagnolo
Copy link
Contributor

LGTM. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcavagnolo bcavagnolo Awaiting requested review from bcavagnolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oldpatricka @bcavagnolo