Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/ben 390 #148

Merged
merged 17 commits into from
Oct 18, 2024
Merged

Dev/ben 390 #148

merged 17 commits into from
Oct 18, 2024

Conversation

bLopata
Copy link
Contributor

@bLopata bLopata commented Oct 7, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Oct 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tutor-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 5:32pm

@bLopata bLopata marked this pull request as ready for review October 8, 2024 18:00
VVoruganti
VVoruganti requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@VVoruganti VVoruganti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API routes and logic around adding and changing the reaction look good, but I think metamessages are overkill for this feature and add extra complexity/latency. A quick switch to using the message's metadata should be cleaner.

api/routers/chat.py Outdated Show resolved Hide resolved
www/components/messagebox.tsx Outdated Show resolved Hide resolved
VVoruganti
VVoruganti requested changes Oct 14, 2024
View reviewed changes
www/components/messagebox.tsx Outdated Show resolved Hide resolved
www/app/page.tsx Outdated Show resolved Hide resolved
www/utils/api.ts Outdated Show resolved Hide resolved
@bLopata bLopata merged commit cd2f445 into main Oct 18, 2024
5 of 6 checks passed
@bLopata bLopata deleted the dev/ben-390 branch October 18, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VVoruganti VVoruganti VVoruganti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bLopata @VVoruganti