Fix 'The "incomplete" option does not exist' in the integration:activ…

…ities command
platformsh · May 3, 2022 · 9439e55 · 9439e55
1 parent 97fcdbd
commit 9439e55
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Command/Integration/Activity/IntegrationActivityListCommand.php b/src/Command/Integration/Activity/IntegrationActivityListCommand.php
@@ -30,6 +30,7 @@ protected function configure()
             ->addOption('start', null, InputOption::VALUE_REQUIRED, 'Only activities created before this date will be listed')
             ->addOption('state', null, InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, 'Filter activities by state.' . "\n" . ArrayArgument::SPLIT_HELP)
             ->addOption('result', null, InputOption::VALUE_REQUIRED, 'Filter activities by result')
+            ->addOption('incomplete', 'i', InputOption::VALUE_NONE, 'Only list incomplete activities')
             ->setDescription('Get a list of activities for an integration');
         $this->setHiddenAliases(['integration:activities']);
         Table::configureInput($this->getDefinition());

diff --git a/src/Service/ActivityLoader.php b/src/Service/ActivityLoader.php
@@ -48,7 +48,7 @@ public function loadFromInput(HasActivitiesInterface $apiResource, InputInterfac
     {
         if ($state === [] && $input->hasOption('state')) {
             $state = ArrayArgument::getOption($input, 'state');
-            if ($input->getOption('incomplete')) {
+            if ($input->hasOption('incomplete') && $input->getOption('incomplete')) {
                 if ($state && $state != [Activity::STATE_IN_PROGRESS, Activity::STATE_PENDING]) {
                     $this->stdErr->writeln('The <comment>--incomplete</comment> option implies <comment>--state in_progress,pending</comment>');
                 }