Fix Find() when / is used as input #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdiluccio
approved these changes
Feb 1, 2024
akalipetis
force-pushed
the
akalipetis/issue-199
branch
from
64de3e1
to
81e7375
Compare
akalipetis
force-pushed
the
akalipetis/issue-199
branch
from
81e7375
to
b3ae9dc
Compare
gilzow
approved these changes
Feb 1, 2024
gilzow
approved these changes
Feb 1, 2024
|
the only other challenge i see is that the message about adding the composer dependency is scrolled out of view quickly due to the size of our congrats message: Normal size terminal window: Expanded to be able to see it: |
|
Good point, let's open a separate issue to discuss this. |
|
message size moved to #204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with Platformifiers that were looking for relative files, like Laravel and Django
Fix #199