Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish release over Sonatype repository. #217

Merged

Conversation

felipebonezi
Copy link
Contributor

Fixes #216

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #217 (a4a87e7) into master (58b3652) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   13.66%   13.66%           
=======================================
  Files           7        7           
  Lines         139      139           
  Branches       10       10           
=======================================
  Hits           19       19           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b3652...a4a87e7. Read the comment docs.

@felipebonezi
Copy link
Contributor Author

@octonato check this out! 😄
Is everything right?

@octonato
Copy link
Contributor

@felipebonezi, sorry I clicked to fast on the button and sent the review without comments.

It's looking good, but we may want to preserve the same if condition in the Travis build.

I will add the credentials for Sonatype to Travis

@octonato
Copy link
Contributor

@felipebonezi, secrets added to travis.

If you change the if condition we can merge this and the snapshot will be published. Assuming I added all credentials correctly.

@octonato
Copy link
Contributor

@felipebonezi, I applied the changes and will merge. Hopefully the snapshot gets published confirming that we setup everything correctly.

@octonato octonato merged commit b191fd2 into playframework:master May 25, 2021
@skiley22
Copy link

The artifacts were not successfully published: https://app.travis-ci.com/github/playframework/play-ebean/jobs/510825770

@octonato
Copy link
Contributor

@skiley22, yes. This is known. We had similar issues in other Play project. The fix is explained here: #219 (comment)

@felipebonezi
Copy link
Contributor Author

@skiley22, yes. This is known. We had similar issues in other Play project. The fix is explained here: #219 (comment)

I've fixed on PR #222
Could you review? 😄

@felipebonezi
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bintray Download for 6.1.0 down
4 participants